[Bug 36058] Available presence seen for a bit when switching from dnd to away

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36058

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-14 03:25:27 PDT ---
(In reply to comment #4)
> (In reply to comment #2)
> > OHHHHHH! That's how it works. privacy_lists_loaded_cb() (the callback for 
> >  get_existing_privacy_lists_async()) is called when receiving the privacy lists
> > from the Google server fails (as it inevitably will), and that function calls
> > toggle_presence_visibility_async(). And this works in the test suite because
> > BaseXmlStream (and hence SharedStatusStream) responds to privacy list queries
> > in the negative by default.
> 
> Oh, I thought conn_presence_set_initial_presence_async() was called.
> 
> > I don't suppose you fancy tidying that up so that Gabble doesn't
> 
> Can try, not sure the results will be good at the first attempt :) (and hey,
> this code is entangled!)

11:25             wjt_ | barisione: re. your last comment on 
                         https://bugs.freedesktop.org/show_bug.cgi?id=36058, 
                         conn_presence_set_initial_presence_async() *is* called
11:25             wjt_ | barisione: but i couldn't see how calling it would end 
                         up actually setting your initial presence in the 
                         shared status case
11:26             wjt_ | barisione: and it turns out to only do so by accident, 
                         because the shared status code path inexplicably calls 
                         into the privacy list code path
11:26        barisione | ah ok
11:26        barisione | now it's clear
11:26             wjt_ | so the tidying up i'm after isn't very big
11:27             wjt_ | it's just making it not try to get privacy lists once 
                         it's verified that the server supports SS

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.