[Bug 33404] Move caps hash stuff to Wocky

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 14 19:53:42 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33404

--- Comment #19 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-14 10:53:41 PDT ---
Argh. I somehow missed the last patch that actually did exactly this. Sorry for
jumping the gun.

(In reply to comment #17)
> Also, I'm not so happy about "default_value_str". I'm open to suggestions.

'raw_value_contents', maybe?

I think it would be better if the filling in of default_value_str when parsing
the form happened before the type stuff: always call extract_value_list, stash
it in default_value_str, and pass that into get_field_value() maybe? This would
mean that we'd not risk accidentally ignoring some spurious extra <value>
elements when calculating a hash.

But functionally it would only change the behaviour for malformed forms; so
maybe I should let it slide.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list