[Bug 35884] Add support for delivery report into TpMessage

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 18 15:29:00 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=35884

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-04-18 06:28:59 PDT ---
http://telepathy.freedesktop.org/spec/Channel_Interface_Messages.html#Simple-Type:Delivery_Report_Header_Key

What do you think about this API:

I think it's good to have a common tp_message_delivery_report_* prefix for
these functions.

TpDeliveryStatus tp_message_delivery_report_get_status (TpMessage *self,
    GError **error);

The error will be constructed using tp_proxy_dbus_error_to_gerror() with
the "delivery-dbus-error" and "delivery-error-message" keys.
I'm sure if this should be part of get_status() or not.

const gchar * tp_message_delivery_report_get_token (TpMessage *self);
TpChannelTextSendError tp_message_delivery_report_get_send_error (
    TpMessage *self);

TpMessage * tp_message_delivery_report_dup_echo (TpMessage *self);

It's a _dup and not a _get as it will have to create a new object.


TpContact * tp_message_delivery_report_get_sender (TpMessage *self);
I find 'sender' a bit confusing but that's what's used in the spec...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list