[Bug 35633] ContactFactory does not introspect Contacts correctly for all protocols

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35633

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #11 from Olli Salli <ollisal at gmail.com> 2011-04-23 04:18:25 PDT ---
Thanks, the new fix is much better. The test and tp-qt4 parts are OK to merge,
but the example needs a small adjustment:

you're currently downloading allKnownContacts immediately after receiving a new
Connection, with no regard to the ContactManager's state. This works if the
connection was there already when starting the example, but is racy on
connection changes - and a racy implementation in example code is a big no-no.
You need to only download allKnownContacts when the state is Success.

This again furthers my thinking that the ContactList D-Bus API should have
separate TemporaryFailure and PermanentFailure states instead of the current
Failure state, so that we could have a feature which only completes until the
ContactManager moves away from the TemporaryFailure state (at which point
allKnownContacts() will be populated, if ever) which apps like this could use.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.