[Bug 35341] Use Connection.Interface.ContactBlocking in Tp::ContactManager

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 28 14:30:23 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=35341

--- Comment #15 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2011-04-28 05:30:21 PDT ---
So, branch updated again.

I rebased on top of master, as Andre suggested, and with that opportunity I
edited and removed some commits.

1st edit is in:

1456eca366ca1ab907c375ede1117b6001580368 - ContactManager::Roster: Finish the
implementation of Conn.I.ContactBlocking introspection

where I simply did not remove the blockedContacts variable just to re-add it
later.


2nd edit is in:

4011e716dbfb7d0f1e78a20aa43af80994b760bb - Contact/ContactManager: Improve the
public interface for blocking/unblocking contacts.

where I adjusted the public interface to have two methods:

 TELEPATHY_QT4_DEPRECATED PendingOperation *blockContacts(
     const QList<ContactPtr> &contacts, bool value);
 PendingOperation *blockContacts(
     const QList<ContactPtr> &contacts);

instead of one with a default (and deprecated) argument.


Then, I removed the commit that added the blockedContacts() public method, as
you suggested.


Real changes begin from:

8c0bd125263e87b00ab95bb0edf48eec79fa0789 - ContactManager::Roster: Introduce a
new contactListContacts set to keep track of the Conn.I.ContactList contacts

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list