[Bug 39543] Implement whitespace pings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39543

Marco Barisione <marco.barisione at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/bari/wocky.git/log/
                   |                            |?h=whitespace-ping

--- Comment #2 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-08-01 09:33:18 PDT ---
http://cgit.collabora.com/git/user/bari/wocky.git/log/?h=whitespace-ping
contains the fix I decided to implement after talking with Will.
http://cgit.collabora.com/git/user/bari/telepathy-gabble.git/log/?h=whitespace-ping
is the tiny corresponding Gabble branch.

The patch removes the code for proper XMPP pings and make WockyPing accepts
only C2S porters.
I'm not entirely sure about this solution as pings could potentially be useful
for direct pings to contacts and because we usually have base Porters, so you
end up having cast code like you can see in the Gabble branch.

There is another problem, one of the 2 ping tests in wocky doesn't work
anymore. I have no idea how to fix it as what we do is:
1. Have 2 different connections
2. Get the first one to send a ping using WockyPing
3. Check the second one gets a XMPP ping
To make it work we would need to change 3 to expect a whitespace ping instead,
but I don't see how as the parser doesn't really care about the whitespaces.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.