[Bug 39543] Implement whitespace pings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39543

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-08-03 03:46:19 PDT ---
(In reply to comment #4)
> Updated, can you please check again?

I think you need to unref res_out in send_whitespace_ping_cb.

Consider this situation:

• sending_queue is empty
• something calls wocky_c2s_porter_send_whitespace_ping_async(); it calls
wocky_xmpp_connection_send_whitespace_ping_async() and sets
sending_whitespace_ping = TRUE;
• something else calls wocky_porter_send_async(); it adds an element to
sending_queue but doesn't try to send it because sending_whitespace_ping;
• send_whitespace_ping_cb is called; it sets sending_whitespace_ping = FALSE
but doesn't flush the queue afaict? I think it should call send_head_stanza()
on the success path.

On the tests: interesting choice to use
wocky_test_stream_set_direct_read_callback not a signal. Not really a criticism
 as such.

> 
> (In reply to comment #2)
> > The patch removes the code for proper XMPP pings and make WockyPing accepts
> > only C2S porters.
> > I'm not entirely sure about this solution as pings could potentially be useful
> > for direct pings to contacts and because we usually have base Porters, so you
> > end up having cast code like you can see in the Gabble branch.
> 
> How about this? Did you look at
> http://cgit.collabora.com/git/user/bari/telepathy-gabble.git/log/?h=whitespace-ping
> ?

I think the cast is fine, inasmuch as the other places we assume the same thing
are fine… I don't really like it but I don't think it's a blocker.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.