[Bug 39796] Can't remove secret params from the keyfile

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39796

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-08-03 05:10:55 PDT ---
(In reply to comment #2)
> 12:07 < smcv> cassidy: hmm, wouldn't it be better if this bit in 
>               mcd-a-m-default.c <http://paste.debian.net/124947/> removed it 
>               from whichever of secrets and keyfile it's not setting it in?
> 12:07 < smcv> cassidy: and for bonus points cope with NULL gracefully, like the 
>               !ENABLE_GNOME_KEYRING case does
> 12:08 < smcv> probably easiest to do: remove_key (secrets, ...); remove_key 
>               (keyfile, ...); if (val != NUL) { if (secret) set(secrets, ...) 
>               else set(keyfile, ...) }
> 12:09 < smcv> cassidy: also, do you get a critical or warning when you 
>               reproduce that bug, symptomatic of calling set(..., NULL)?


_set() is not called in this case, _delete() is, so that won't solve this
issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.