[Bug 39660] high-level API for Connection.Interface.ContactGroups

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39660

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-08-03 07:05:47 PDT ---
Review of attachment 49875:
 --> (https://bugs.freedesktop.org/review?bug=39660&attachment=49875)

::: telepathy-glib/connection-contact-list.c
@@ +1011,3 @@
+ *
+ * When this feature is prepared, the contact groups properties of the
+ * Connection has been retrieved.

I'd list all the properties needing this feature to be prepared. You should
also mention that the 3 sigs won't be fired until this has been prepared.

::: telepathy-glib/connection.c
@@ +2024,3 @@
+   * #TpContact::contact-groups-changed signals that add some members. When
this
+   * signal is emitted, #TpConnection:contact-groups property is already
+  param_spec = g_param_spec_uint ("group-storage",

You should document that those signals need the feature to be prepared.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.