[Bug 39660] high-level API for Connection.Interface.ContactGroups

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39660

--- Comment #4 from Xavier Claessens <xclaesse at gmail.com> 2011-08-03 12:00:19 PDT ---
(In reply to comment #3)
> Review of attachment 49875 [details]:
> 
> ::: telepathy-glib/connection-contact-list.c
> @@ +1011,3 @@
> + *
> + * When this feature is prepared, the contact groups properties of the
> + * Connection has been retrieved.
> 
> I'd list all the properties needing this feature to be prepared. You should
> also mention that the 3 sigs won't be fired until this has been prepared.

Other feature documentation does not do that, afaik. IMO it is too easy to get
it outdated when adding new properties. Each property says which feature needs
to be prepared already.

> ::: telepathy-glib/connection.c
> @@ +2024,3 @@
> +   * #TpContact::contact-groups-changed signals that add some members. When
> this
> +   * signal is emitted, #TpConnection:contact-groups property is already
> +  param_spec = g_param_spec_uint ("group-storage",
> 
> You should document that those signals need the feature to be prepared.

done

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.