[Bug 38142] proxy factories

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Aug 5 12:08:31 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38142

--- Comment #73 from Xavier Claessens <xclaesse at gmail.com> 2011-08-05 03:08:30 PDT ---
(In reply to comment #71)
> • Deprecate tp_account_manager_ensure_account()
> 
> Speaking of which: why is tp_account_manager_ensure_account() not just a
> wrapper around the equivalent call to
> tp_simple_client_factory_ensure_account()? I guess it's down to the fact that
> the former doesn't return a ref, whereas the latter does? Annoying if so—but
> does tp_account_manager_ensure_account() need to fire off a call to
> tp_proxy_prepare_async()?
> 
> (Oh! for an autorelease pool.)

Yes, legacy_accounts table is just there to keep compatibility, because
previous API does not return a ref and was keeping one for the user...
sadness...

> • TpBaseClient: prepare TpAccount, TpConnection and TpChannels with factory
> desired features

reduced that patch to keep only what's needed, the refactor to reduce code
duplication can be done later separately. sorry for the massive patch, it's now
gone.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list