[Bug 37145] Replace low level network code with GIO

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Aug 7 17:29:11 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37145

--- Comment #6 from Debarshi Ray <debarshi.ray at gmail.com> 2011-08-07 08:29:10 PDT ---
(In reply to comment #5)

I have update my branch. Could you please take another look at it?

> * g_idle_add(io_err_cleanup_func, conn); idle destroys again ?

This is a relic from the previous code. The reason I have still kept it is that
the _read_async was called on the input_stream which is a part of the
priv->socket_connection object and the disconnect method unrefs this same
object. I am not sure how that will play out if I don't leave the main loop.

> * iface_send_impl is using a blocking write. it shouldn't.. :)

Another relic from the past. This is closely related to my above question. In
short, if I do an asynchronous write and detect a problem in the callback, then
can I disconnect without without leaving the mainloop?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list