[Bug 37145] Replace low level network code with GIO

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37145

--- Comment #11 from Sjoerd Simons <sjoerd at luon.net> 2011-08-10 07:12:01 PDT ---
(In reply to comment #10)
> > * The following breaks SSL:
> >    priv->io_stream = g_tcp_wrapper_connection_get_base_io_stream(
> >         G_TCP_WRAPPER_CONNECTION(socket_connection));
> 
> Fixed. But the connect/connect-success-ssl.py test is failing, although I can
> connect to Freenode. Wondering if this has something to do with self-signed
> certificates.

It does, gtls does quite strict checking  by default. We should for-now switch
back to check at the same level as the old code and for the future implement
SSL connection channel

> > * CloseAsyncData and WriteAsyncData seem mostly useless. As both operations
> > only should run once per 
> >    connection object just keep the state in the priv data structure (shoulod
> > simlify the code).
> 
> What if the send interface is invoked twice in succession before the first one
> has completed? Then the contexts would get mixed up, won't they?

That case is already broken (didn't catch it before, sorry), you can't call
_write_async on a GOutputStream when the previous async operation hasn't
finished yet. To implement that kind of API you need to implement some
buffering yourself

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.