[Bug 43421] New: TpSimpleHandler doc uses deprecated symbol in example

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43421

             Bug #: 43421
           Summary: TpSimpleHandler doc uses deprecated symbol in example
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: xclaesse at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


The example code uses tp_simple_handler_new() which is deprecated.

The reason it is deprecated is that constructor was calling
tp_account_manager_dup() internally but some handlers does not want a full AM
to be prepared, so tp_simple_handler_new_with_am() and
tp_simple_handler_new_with_factory() where introduced.

So the example should be changed to use one of those. Similar change needs to
be done for observer/approver.

Fix:
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=fix-example

Another solution that I personally prefer is undeprecate
tp_simple_handler_new() but slightly change its behaviour and stop creating a
TpAM internally but create a TpAutomaticClientFactory instead. It could also
accept NULL TpDBusDaemon and use internally tp_dbus_daemon_dup(). Like that we
simplify basic use cases where all the app wants is just handling channels.

Fix:
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=base-client


Make your choice of which branch to merge :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.