[Bug 24901] voicemail interface usable with at least GSM and Skype

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24901

--- Comment #43 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-12-05 08:40:47 PST ---
I've only looked at the commits since Will's latest patches.

The RecordVoicemail property MUST be set True before emitting this signal, as
well as DiversionReason, any other properties whose values can now be
determined by the Connection Manager.

^ This is really unclear. Can you just reword a bit to make a little easier to
understand please?

+ <tp:rationale>
+ Provided for state recoverability by Observers.
+ </tp:rationale>

You could link Observers.

I didn't really look at the rest of this branch or even this bug so haven't
followed rationales, but your latest five patches look fine except the two
comments above.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.