[Bug 41897] Generate code for Call1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41897

--- Comment #11 from Xavier Claessens <xclaesse at gmail.com> 2011-12-09 01:31:34 PST ---
For the record, here are Olivier's comments:

<ocrete> your tp-fs branch looks good (except that we should fix the
controlling/endpoint thing)
<ocrete> please split/rename the "misc fixes" commit

<ocrete> in gabble.. call_member_flags_changed_cb() is always because of
progres_made ?
<ocrete> 22:39:55> did you just put progress_made everywhere ?
<ocrete> we have to propagate the correct reasons

<ocrete> updated is always false when coming to the other side I think.. its
meaningless anyway its only for client->cm communications
<ocrete> also, gabble needs to know if each new MD was accepted or not..
<ocrete> so the callback shouldnt be NULL

<ocrete> in codec_array_to_list() the updated codec is useful because gabble
should only send <description-info> for those codecs where it is set to TRUE
instead of trying to do diff (so we can delete from code in the
jingle-media-rtp.c

<ocrete> for the remote contact == 0.. it means for all contacts

<ocrete> with xmpp, it's never ICE-lite

<ocrete> TP_IFACE_CHANNEL_TYPE_CALL ".InitialAudio" -> isnt there a define for
these already ?
<ocrete> like TP_PROP_CHANNEL_TYPE_CALL_INITIAL_AUDIO

<ocrete> I also wonder if sending state succesful completions shouldnt also be
reported to the CM

<ocrete> 02:49:08> xclaesse: you empathy branch just looks good. I can'T find
anythign to say about it !

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.