[Bug 43826] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43826

--- Comment #1 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-12-20 09:18:30 PST ---
Here goes a review, all in all looks good to me, just some minor details.

+ * Download the contact list when it is not done automatically at
+ * connection
Missing dot "connection."

+ * If the #TpBaseContactList subclass does not implement
+ * %TP_TYPE_MUTABLE_CONTACT_LIST, it is an error to call this method.

Maybe
"This method should only be used if the #TpBaseContactList subclass implements
%TP_TYPE_MUTABLE_CONTACT_LIST."

But I see that other methods use "it is an error to call this method", so
change it if you feel the need.

Otherwise seems good to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.