[Bug 33660] Add tp_debug_sender_is_enabled()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33660

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-02-04 04:22:37 PST ---
+ * tp_debug_sender_vprintf_message:
[snip]
+ * tp_debug_sender_printf_message:

I preferred Will's function name suggestions, add_message_vprintf and
add_message_printf.

+#ifndef ENABLE_DEBUG_CACHE
+  if (self->priv->enabled || formatted != NULL)
+    {
+#endif

Instead of indenting the whole function couldn't you do:

#ifndef ENABLE_DEBUG_CACHE
  if (!self->priv->enabled && formatted == NULL)
    return;
#endif

+      if ((when = timestamp) == NULL)

Can we just split this into two lines please?

+ * formats and adds a new message to the debug sender message queue. If the

Capital F!

+ * @timestamp: Time of the message, or %NULL for right now

Just out of interest, why is this different from _add_message in that it
doesn't have a fallback to now? It'd be cool if they were all consistent,
whatever the behaviour is.

+ * Since: UNRELEASED

Usual style is major.minor.UNRELEASED but it doesn't really matter as it's
going to get sedded out later anyway.

You haven't added the new functions to the gtk-doc sections file so I'm
guessing you haven't run make check or distcheck?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.