[Bug 33546] Refactore and cleanup TplEvent/TplEventText

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33546

--- Comment #2 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-02-06 17:05:13 PST ---
Looks mostly good. Just two comments:

+static void
+received_data_free (gpointer arg)
+{
+  ReceivedData *data = arg;
+  g_free (data->log_id);
+  g_free (data->text);
+  g_slice_free (ReceivedData,data);
+}

Why gpointer arg and not ReceivedData *data ?

Please split this into smaller commits. At the very least, the pidgin bug fix
should be a different one. And if you can split it even more (e.g. one commit
for removing the setters, another one for making props construct-only...), even
better.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.