[Bug 33991] Should allow Tp::AccountManager::filterAccounts() before FeatureCore is ready

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Feb 13 12:59:05 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33991

--- Comment #2 from Olli Salli <ollisal at gmail.com> 2011-02-13 03:59:05 PST ---
A problem with that is you can't reliably wait for accountAdded. Consider the
situation in which there are no accounts - then you end up waiting forever!
Hence, you need at least one async roundtrip which doesn't imply waiting for
any particular accounts to appear, just the fact that the initial state has
been downloaded (which is exactly what becomeReady() finishing means).

Somebody has to call becomeReady anyway to make the accounts appear in the set
in the first place. Why not wait for that becomeReady call to finish properly
at that? You'll have to do it anyway to handle any possible errors. If the
implementation of filterAccounts called becomeReady internally, it'd have to
return a PendingOperation to relay these errors (and the fact that the account
set with its accounts (or none) is now there) - which I think is undesirable.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list