[Bug 28423] Conn.I.Blocking: replacement for the 'deny' ContactList channel

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Feb 14 12:03:36 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=28423

--- Comment #7 from Sjoerd Simons <sjoerd at luon.net> 2011-02-14 03:03:35 PST ---
Some small nitpicks:

* I don't think BlockContacts ([12,3,4], True) should return NotCapable when
you can't report abuse on
   the protocol.

If a UI gets as far as to calling BlockContacts then it's basically to late to
tell it this doesn't actually works (the user already clicked apply etc). The
UI only has three options when this happens:

- It ignores the error, contact not actually blocked, bad
- It throws an error in the users face, bad
- handles the error by calling BlockContacts with abuse= False...

Assuming you can get this far, the last one is least bad way of handling it
imho. So better to make that the normal behaviour; If the protocol doesn't
support reporting abuse, the value of the abuse parameter is just ignored..

* Maybe the change notification should have a b: Abuse flag as well to indicate
what happened?
* Less importnat, do we need a Protocols.Interface.Deny with some capabilities
as well ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list