[Bug 31274] Call: NewCodecOffer signal should contain the properties of the optional CodecOffer interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31274

--- Comment #12 from David Laban <david.laban at collabora.co.uk> 2011-02-14 09:17:26 PST ---
ocrete: I'm not a massive fan of your changes.

"The whole point of a content is that you have a single source that you
broadcast to everyone. " in comment 11 confused me for a second because I
thought you meant that you broadcast the same media to everyone. I guess what
you mean is that you broadcast the same description to everyone?

Am I right in assuming that RemoteMediaDescriptions is what each remote side
can receive/decode, and the LocalMediaDescription is what you were able to
accept from remote peers.

what do we do we put in LocalMediaDescription the following muji case: 
userA says h264 is id 104, vp8 is id 105
Farstream accepts the offer, saying it can support both codecs
userB says vp8 is id 104, h264 is id 105
Farstream accepts the offer, saying it can support both codecs

I think that we either want it to remain as a map from user to properties, or
not exist at all (in this case, UpdateLocalMediaDescription would need a remote
member argument as well). I hope that either you or sjoerd can put me right and
explain why you made this decision on Friday.

I like the rename to UpdateLocalMediaDescription. I don't think you've fully
justified the reason for calling it with Renegotiate=False vs Renegotiate=True
though. Also, I'm not quite sure why our streaming implementation would
suddenly decide to renegotiate codecs: has your DSP suddenly realised that it
can accelerate h264 or something? An example of each would be good.

Also, when I checked it out and ran make, I got:
 WARNING: Key 'RemoteCodecs' not known in namespace
'org.freedesktop.Telepathy.Call.Content.MediaDescription.DRAFT'
         (<tp:dbus-ref> in
Interface(org.freedesktop.Telepathy.Call.Content.Interface.Media.DRAFT2))

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.