[Bug 34316] UpdateParameters: bad handling of DBus_Property and Has_Default in Unset argument

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34316

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UpdateParameters: bad       |UpdateParameters: bad
                   |handling of DBus_Property   |handling of DBus_Property
                   |in Unset argument           |and Has_Default in Unset
                   |                            |argument

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-02-16 02:48:55 PST ---
Already noted in the source:

        /* pessimistically assume that removing any parameter merits
         * reconnection (in a perfect implementation, if the
         * Has_Default flag was set we'd check whether the current
         * value is the default already) */

I believe this applies equally to parameters that are not a DBusProperty: if
you have an account with { 'ignore-ssl-errors': False } in Parameters, the
default is also False, and you unset 'ignore-ssl-errors', then we shouldn't ask
for reconnnection.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.