[Bug 32702] TpContact should have properties for ContactGroups

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32702

--- Comment #9 from Xavier Claessens <xclaesse at gmail.com> 2011-02-21 01:47:10 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > > + * @n_groups: the length of @groups, or -1 if @groups is %NULL-terminated
> > > + * @groups: (array length=n_groups) (allow-none): the set of groups which the
> > > + *  contact should be in (may be %NULL if @n_groups is 0)
> > > 
> > > Is this binding friendly? Maybe it is, I'm just wondering.
> > 
> > Should be, yes. Now I changed a bit to do like in
> > tp_base_contact_list_groups_created()
> 
> gir will understand the -1 if @groups is %NULL-terminated logic?
> Maybe check with Tomeu just to be sure that this API is gir friendly?

It don't need to understand the -1, bindings will always give len value. The -1
is only extra convenience for C apps.

> > > Did you valgrind your tests?
> > 
> > How do I run it with valgrind?
> 
> make -C tests/dbus check-valgrind TESTS=test-badger

When passing only the contact-groups it works fine, but it seems avatar test
case has leaks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.