[Bug 34027] Salut should have a plugin API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34027

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-24 10:53:13 PST ---
+  g_ptr_array_foreach (tmp, add_to_array, managers);
+  g_ptr_array_free (tmp, FALSE);

+      g_ptr_array_foreach (managers, copy_to_other_array, out);
+      g_ptr_array_free (managers, TRUE);

Same review comment as for the corresponding code in Gabble.


+/* The return type should be a new GPtrArray* which will be freed
+ * straight after this function is called, so the pointer array must
+ * not have a free function. */

Really, you should say that the caller takes ownership of the array and of the
references to channel managers within it, and maybe refer to
TpBaseConnectionCreateChannelManagersImpl which has the same semantics?

“Protocol: allow the name, icon name and English to be set easier”

Nice troll!


-  name = g_strdup_printf ("%s." SALUT_DNSSD_PRESENCE ".local", _self->name);
+  const gchar *dnssd_name;
+
+  dnssd_name = salut_avahi_discovery_client_get_dnssd_name (
+      priv->discovery_client);
+
+  name = g_strdup_printf ("%s.%s.local", dnssd_name, _self->name);

This looks wrong: I think you've got the order of the two arguments wrong?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.