[Bug 34824] Turn WockyPorter into an interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34824

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-28 09:32:17 PST ---
+ * wocky-c2s-porter.c - Source for WockyC2SPorter
+ * Copyright (C) 2009 Collabora Ltd.

This seems unlikely.

- * Copyright (C) 2009 Collabora Ltd.
- * @author Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
+ * Copyright (C) 2011 Collabora Ltd.

This is also unlikely. It should presumably be 2009–2011.

+  guint (*register_handler_from_stanza) (

I don't really like the naming here. Of course, it's my fault because I called
the original function register_handler_from. Maybe we should call the stanza
variants _by_stanza or similar? I'm not overly hung up on this.

Why is register_handler_from_server() on the generic interface? The link-local
porter has no such concept, so I wonder if that should be a method on
WockyC2SPorter.

+const gchar * wocky_porter_get_full_jid (WockyPorter *self);
+const gchar * wocky_porter_get_bare_jid (WockyPorter *self);
+const gchar * wocky_porter_get_resource (WockyPorter *self);

I suppose these are less contentious, although link-local JIDs don't generally
have resources.

 static void
 wocky_porter_default_init (WockyPorterInterface *iface)
 {
+  GType iface_type = G_TYPE_FROM_INTERFACE (iface);
+  static gboolean initialized = FALSE;
+  GParamSpec *spec;
+
+  if (initialized)
+    return;

Should probably use g_once_init_enter()?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.