[Bug 33903] Use convenience methods of TpDebugSender

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33903

David Laban <david.laban at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-

--- Comment #7 from David Laban <david.laban at collabora.co.uk> 2011-05-31 15:21:34 PDT ---
Okay, so I added test-debug from gabble and made it a bit stricter
http://cgit.freedesktop.org/~alsuren/telepathy-rakia/log/?h=test-debug. On
origin/master, distcheck (with debugging disabled) fails (kind-of as expected).


I then merged your branch into mine (with a billion conflicts because of my
rename :( ) and distcheck failed.

This was mostly because you fail to do:
#define DEBUG(format, ...) G_STMT_START { } G_STMT_END
to make it swallow the macro args properly (this is what gabble does) and then
there were a few unused variable definitions that needed #ifdefing.

I fixed this in
http://cgit.freedesktop.org/~alsuren/telepathy-rakia/log/?h=test-debug-lite

Taking a look at your code again, there are a few niggles that I fixed in my
merge/post-merge commits, but:

-    DEBUG ("Couldn't resolv STUN server address, ignoring.");
+    MESSAGE ("could not resolve STUN server address, ignoring");

Is there any reason why you decided to break the case/punctuation in that debug
message? Would it be better to instead standardise on correct case/punctuation
in all debug messages?

Also, I don't like this: 
{
"created",
- "invite-sent",
- "invite-received",
- "response-received",
+ "invi-sent",
+ "invi-recv",
+ "resp-recv",
"active",
- "reinvite-sent",
- "reinvite-received",
- "reinvite-pending",
+ "rein-sent",
+ "rein-recv",
+ "rein-pend",
"ended"
};
so I reverted it.

Annoyingly, my merge commit makes gitg segfault. If you want to rebase your
branch and check that it's all correct using git diff then that might be a good
solution. Otherwise, I can try to fix gitg.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.