[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jun 2 20:56:31 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37034

--- Comment #14 from Daniele E. Domenichelli <daniele.domenichelli at gmail.com> 2011-06-02 11:56:30 PDT ---
Yeah sorry, I definitely missed #c9
Updated and added some unit tests for FileTransferChannelCreationProperties and
for Account::createFileTransfer() method,
I'm not sure if the last one is what I was supposed to test, anyway the tests
for that method are missing

A problem I noticed is that the channel is requested even if the
FileTransferChannelCreationProperties is not valid (not only by using the path
constructor, but also using the default constructor). Maybe an error should be
returned before requesting the channel, but the method returns a
PendingChannelRequest* and therefore it is not possible to return a
PendingFailure*, maybe a PendingChannelRequestFailure class should be
implemented? Or should it be left as it is now and just start the request
waiting for the failure from CM?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list