[Bug 37861] Memory leak in collect_satisfied_requests in mcd-dispatch-operation.c

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jun 3 10:39:14 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37861

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |r+

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-06-03 01:39:13 PDT ---
Looks OK. One additional enhancement you could make:

> - g_ptr_array_unref (satisfied_requests);
> + free_satisfied_requests (satisfied_requests);

Consider giving satisfied_requests g_free as a free-function, which would mean
the last unref automatically frees its contents.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list