[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Olli Salli <ollisal at gmail.com> 2011-06-05 09:46:14 PDT ---
(In reply to comment #17)
> I updated the branch again and I found out why it was causing SIGSEGV.
> In account-channel-dispatcher.cpp the method
> TestAccountChannelDispatcher::testPCR is always checking if
> channelRequest()->channel().isNull(), but if the constructor by errorName and
> errorMessage of pendingChannelRequest is used, then channelRequest() is null...

Makes sense.

> I fixed it checking if channelRequest().isNull() before doing other stuff, but
> I'm not sure if I should set the channel somehow...

No, this was purely a limitation of the test. Actual operation of the API, even
with supposedly correct parameters, can result in a null ChannelRequest if the
initial D-Bus call to the ChannelDispatcher fails (as that call would return
the object path of the ChannelRequest). It's perfectly consistent that the
early-out case for invalid parameters gives a null channel request as well
(because there isn't one).

I'm merging this now. Will be in 0.7.1. Thanks again for your work!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.