[Bug 38060] message-mixin: check we have >= 2 parts before accessing the second one

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jun 8 10:03:28 CEST 2011


Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |pochu27 at gmail.com

--- Comment #3 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-06-08 01:03:27 PDT ---
Not a tp-glib reviewer, but:

Looks good to me.

-      if (echo != NULL)
+      if (echo != NULL && echo->len >= 1)

I guess echo->len should always be > 0, right? If so perhaps a g_warning or a
DEBUG could be useful in order to notice the problem and fix the CMs.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list