[Bug 29777] Ridiculously low unit test coverage

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29777

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|telepathy-bugs at lists.freede |andrunko at gmail.com
                   |sktop.org                   |
                 CC|                            |ollisal at gmail.com

--- Comment #5 from Olli Salli <ollisal at gmail.com> 2011-06-08 08:47:50 PDT ---
Andre is working on cleaning up the test suite so the test coverage can be more
easily improved. His WIP branch is at
http://cgit.collabora.com/git/user/andrunko/telepathy-qt4.git/log/?h=tests-cleanup.
That doesn't increase the test coverage yet, but rather enables doing so.

I'll have to leave in a minute, but some quick observations:

     add_subdirectory(glib)
+    add_subdirectory(glib-helpers)

The "glib" subdirectory means "this is GLib code, from tp-glib". So I'd rather
not use the naming glib-helpers: just put it in top-level tests/lib/?

+    TestConnHelper(Test *parent,
+            GType gType, const QString &account, const QString &protocol);
+    TestConnHelper(Test *parent,
+            const Tp::ChannelFactoryConstPtr &channelFactory,
+            const Tp::ContactFactoryConstPtr &contactFactory,
+            GType gType, const QString &account, const QString &protocol);


Why separate ctors for passing factories or not - couldn't you do the same, and
additionally enable passing only a channel factory, by using default
parameters. You can't obviously for the varargs one though, so arguably this
could be OK for consistency reasons.

I'll review thoroughly tomorrow.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.