[Bug 29777] Ridiculously low unit test coverage

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29777

--- Comment #7 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-06-09 09:00:04 PDT ---
(In reply to comment #5)
>      add_subdirectory(glib)
> +    add_subdirectory(glib-helpers)
> 
> The "glib" subdirectory means "this is GLib code, from tp-glib". So I'd rather
> not use the naming glib-helpers: just put it in top-level tests/lib/?
tests/lib does not depend on glib code and tests/lib/glib is glib specific,
hence the new glib-helpers, no change here.

> +    TestConnHelper(Test *parent,
> +            GType gType, const QString &account, const QString &protocol);
> +    TestConnHelper(Test *parent,
> +            const Tp::ChannelFactoryConstPtr &channelFactory,
> +            const Tp::ContactFactoryConstPtr &contactFactory,
> +            GType gType, const QString &account, const QString &protocol);
> 
> 
> Why separate ctors for passing factories or not - couldn't you do the same, and
> additionally enable passing only a channel factory, by using default
> parameters. You can't obviously for the varargs one though, so arguably this
> could be OK for consistency reasons.
> 
This was added for consistency, so no change here.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.