[Bug 37844] Don't try to reconnect an account over and over for certain errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37844

Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47990|0                           |1
        is obsolete|                            |

--- Comment #6 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-06-16 02:53:03 PDT ---
Created an attachment (id=48028)
 View: https://bugs.freedesktop.org/attachment.cgi?id=48028
 Review: https://bugs.freedesktop.org/review?bug=37844&attachment=48028

Check for the specific error codes when reconnecting

> If you're going to switch away from using abort_reason (which I would
> encourage!), I'd suggest not using abort_reason in this conditional at all.
> 
> Perhaps factor out a function:

Sounds good, I've done that, adding TP_CONNECTION_STATUS_REASON_NONE_SPECIFIED
too as the old check had.

I've tested a couple of scenarios and it works fine:

(process:19287): mcd-DEBUG: connection_should_reconnect: error code
org.freedesktop.Telepathy.Error.SoftwareUpgradeRequired, not reconnecting

(process:19287): mcd-DEBUG: connection_should_reconnect: dbus error code:
OWNER_LOST, reconnecting

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.