[Bug 38524] TpChannel: priv->handle_type overrided during object construction

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38524

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-06-21 07:00:51 PDT ---
Review of attachment 48228:
 --> (https://bugs.freedesktop.org/review?bug=38524&attachment=48228)

r+

::: telepathy-glib/channel-iface.c
@@ +97,3 @@
     param_spec = g_param_spec_uint ("handle-type", "Handle type",
         "The TpHandleType of this channel's associated handle.",
+        0, G_MAXUINT32, TP_UNKNOWN_HANDLE_TYPE,

Well, this feels a bit sketchy because TP_UNKNOWN_HANDLE_TYPE is not really a
TpHandleType: but the property is already documented to have this value in some
cases, as is tp_channel_get_handle(). So this is fine!

Good catch, I would never have thought of looking here.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.