[Bug 38605] TpChannelRequest: add API for properties

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jun 24 11:24:04 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38605

--- Comment #3 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-06-24 02:24:04 PDT ---
Review of attachment 48370:
 --> (https://bugs.freedesktop.org/review?bug=38605&attachment=48370)

Looks good. One question...

::: telepathy-glib/channel-request.c
@@ +687,3 @@
+tp_channel_request_get_user_action_time (TpChannelRequest *self)
+{
+  if (path == NULL)

Is -1 correct here? Perhaps it should be 0 or maxint64.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list