[Bug 31192] When the person that invited leaves a chat invitation is launched

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jun 27 12:50:13 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=31192

--- Comment #4 from Simon Schampijer <simon at schampijer.de> 2011-06-27 03:50:11 PDT ---
I have been doing some more analysis of the issue. The scenario is:

- open an activity on machine A

- invite machine B to it

- join the invitation on machine B

- quit activity in machine A

---> a new invitation on machine B is launched, a chat activity in the color of
machine B

When A quits the activity it tries to revoke the invitations and calls
'salut_olpc_activity_revoke_invitations' (
http://cgit.freedesktop.org/telepathy/telepathy-salut/tree/src/salut-olpc-activity.c?h=telepathy-salut-0.4#n680
). As I understand it, this revokes the invitations that have been done to
machines that have not accepted that invitation at this moment yet. For example
A invites B and C, B did join, A quits and at that point the invitation to C
should be revoked (side note: this actually is not handled cleanly see
http://dev.laptop.org/ticket/11020). 

We seem to keep track of the invitations done and when it is accepted we try to
remove the contact from our list (
http://cgit.freedesktop.org/telepathy/telepathy-salut/tree/src/salut-self.c?h=telepathy-salut-0.4#n978
). The problem is that we do not get the SALUT_CONTACT_OLPC_ACTIVITIES changes
on A (ActivitiesChanged), we only get signaled that the current activity of B
changed. So we do not remove B from our list of invitations and hence when we
quit the activity we try to revoke the invitation. I compared with a another
sharing scenario without invitations where A shares publicly and B joins: here
we do get the 'ActivitiesChanged' signal on A when B joins.

It would be great if someone could comment on my findings and analysis from
above, thanks in advance.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list