[Bug 38366] Should fallback to Offline instead of Busy if Invisible is not supported

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38366

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-06-28 03:21:24 PDT ---
(In reply to comment #6)
> (In reply to comment #3)
> > If your AutomaticPresence is invisible and you're connecting in order to
> > request a channel
> 
> Is there any client actually using that feature?

I think it's the right thing for collaborative applications: if I say "share
this document" in AbiWord, it should be able to offer me an account chooser and
fire off a TpAccountChannelRequest with no further MC interaction, even if I'm
not currently online. But if you think this feature is useless, I'd still like
a regression test that demonstrates that MC does something vaguely sensible
instead of crashing (i.e. the channel request fails, probably).

Regression tests that this feature should have include:

* be online, go invisible (via RequestedPresence), connection doesn't
  support it, fall back to disconnecting

* be offline, AutomaticPresence = invisible, go online for a channel request,
  connection doesn't support it, either Disconnect() is called without calling
  Connect (request fails gracefully [1]) or the fallback is to busy

* be offline, go invisible (via RequestedPresence), connection doesn't
  support it [2], Disconnect() is called without first calling Connect()

[1] We'd probably need a new error, WouldBreakInvisibility? Or you could
    remove the feature entirely and only allow channel requests on online
    accounts, but that would make me very sad.

[2] This won't do what you hope it does - Gabble can't announce definite
    support for invisibility until it has nearly finished connecting.
    So we probably need Gabble changes, to make it always allow
    setting invisible presence before going online, then if it discovers
    lack of invisibility support, disconnect with WouldBreakInvisibility
    instead of sending initial presence.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.