[Bug 38852] New: Call: Name methods like methods and signals like signals

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38852

           Summary: Call: Name methods like methods and signals like
                    signals
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-spec
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: david.laban at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: olivier.crete at ocrete.ca


The StreamedMedia api is embarrassing. Let's not make the same mistake in Call

git grep '<method' spec/*Call* shows the following questionable names:

spec/Call_Content_Interface_Media.xml:    <method name="Error"
spec/Call_Stream_Interface_Media.xml:    <method name="CandidatesPrepared"
spec/Call_Stream_Interface_Media.xml:    <method name="Error"

git grep '<signal' spec/*Call* reveals only:

spec/Call_Stream_Interface_Media.xml:    <signal name="PleaseRestartICE"

I plan to change PleaseRestartICE to ICERestartRequested (and have a boolean
ICERestartPending for state recovery) as part of #35012 though, so no need to
worry about that one.

CandidatesPrepared could be called FinishInitialCandidateBatch, but that's a
horrible name. As someone who has been screwed both by failing to call this
method in sip and failing to flush sockets in unix, I'm tempted to call it
FlushCandidates. Thoughts?

The Error methods could both be called RemoveWithError.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.