[Bug 34824] Turn WockyPorter into an interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34824

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-01 05:43:11 PST ---
  * To match stanzas from any sender, see
- * wocky_porter_register_handler_from_anyone(). To match stanzas sent by the
- * server, see wocky_porter_register_handler_from_server().
+ * wocky_porter_register_handler_from_anyone().

I think it'd be good to explicitly say “If you're using a WockyC2S porter, you
can match stanzas sent by the server using wocky_c2s_porter_…”. Otherwise it
will be easy to miss that it exists.

> Shall we change _va to _by_va at the same time? I
> guess blah_va is more common.

The _va suffix doesn't bother me as much. It's standard, and doesn't look as
weird in English.

> I wondered what to do about the from_server and the get_full_jid, bare_jid and
> resource functions but decided on just leaving them in the interface because
> full jids, bare jids, resources and servers all exist in the huge majority of
> XMPP -- non-link-local. If  we were to throw them into the c2s-porter directly
> then implement some other porter which has something to do with normal XMPP
> then we'll have more identical porter-specific functions. Admittedly, at that
> point they could be added to the interface.

I think it's fine to leave them on the interface. In theory you could have a
resource on link-local, though it's unlikely… code dealing with link-local will
just have to cope with get_resource possibly returning NULL. As long as it
returns NULL rather than crashing …

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.