[Bug 34907] Need tp_text_channel_get_message_types()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 2 13:59:41 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34907

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-03-02 04:59:41 PST ---
(In reply to comment #3)
> 12:01              wjt | cassidy: comments like +      /* Copy the array */
> 12:01              wjt | cassidy: don't add anything

Why on earth did I write that? I hate this kind of comments as well. Removed
(squashed).

> 12:01              wjt | cassidy: +      DEBUG ("Channel doesn't have 
>                          Messages.MessageTypes in its "
> 12:01              wjt | +          "immutable properties");
> 12:01              wjt | cassidy: include the channel's path

Done.

> Also I imagine API like gboolean tp_text_channel_supports_message_type
> (TpTextChannel *, TpChannelTextMessageType) might be useful in C, where it's a
> PITA to check whether a GArray contains an element. Not a merge blocker.

All cool kids use javascript these days. :p
But yeah, that's a good idea, I've added it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list