[Bug 34907] Need tp_text_channel_get_message_types()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 2 15:06:21 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34907

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-03-02 06:06:20 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > 12:01              wjt | cassidy: comments like +      /* Copy the array */
> > > 12:01              wjt | cassidy: don't add anything
> > 
> > Why on earth did I write that? I hate this kind of comments as well. Removed
> > (squashed).
> 
> But you didn't remove the thing right below it…
> 
> +      /* Create an empty array */
> +      self->priv->message_types = g_array_new (FALSE, FALSE,
> +          sizeof (TpChannelTextMessageType));

removed (squashed).

> + * Check if message of type @type can be send on this channel.
> 
>                                           ^^^^ should be ‘sent’
> 
> ditto the next line.

fixed (squashed).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list