[Bug 34716] Split wocky_porter_register_handler up to make sender matching more explicit.

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Mar 3 15:53:45 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34716

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-03 06:53:45 PST ---
32ddfbaf559dbb1 confuses me. I read the commit message and the comment in the
test and it appears to want to check that gabble doesn't crash when a roster
push with no id attribute comes in. That's great.

But it also appears to say that Will has added code to discard such stanzas,
except in the test you check that the roster push has succeeded? What am I
missing?

fyi I opened bug #34975 about the unknown IQ handler in GabbleConnection. I
didn't realise the porter didn't do this already!

POW, REVIEW DONE!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list