[Bug 34983] Internally use GDateTime for date computation

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Mar 4 02:01:10 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34983

--- Comment #2 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-03-03 17:01:09 PST ---
This looks pretty good.

I had originally wondered if you should just pass GDateTimes around in the API,
but then you have to manage their memory which seems like a pain in the neck.

The only potential downfall I can see of using gint64s throughout is that you
could potentially mix up localtime and unix time? You code here looks correct,
but it's a mistake someone could possibly make in the future? This could
potentially be mitigated with a TplUnixTimestamp64 typedef, although it then
requires people to use it and think and understand, so maybe it's not useful.

Does this branch remove all of the time_ts from the API? I thought you'd said
there were still some left in the public API, but greping didn't find them.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list