[Bug 34978] Add international encodings to C.I.Cellular

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 7 19:59:53 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34978

--- Comment #3 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-03-07 10:59:53 PST ---
(In reply to comment #2)
> +          Other valid character set are specified in the GSM standard and are,
> +          for instance, “turkey”, “spain” or “portugal”.
> 
> You should link to the GSM standard, ideally… Which of the many zip files in
> http://www.3gpp.org/ftp/specs/archive/23_series/23.038/ should one look at?

The most recent one. They are different revisions of the same document, so I
cannot just link to one as it will become outdated.

> I think the strings should be written as <code>"turkey"</code> in the spec,
> rather than with curly quotes.
>
Done.

>  SMSes will be
> +          encoded in the normal 7-bit GSM character set or in UCS-2, based on
> +          the value of the
> +          <tp:member-ref>MessageReducedCharacterSet</tp:member-ref> property.
> 
> … and whether the message can be represented by the normal 7-bit character set?

Done.

> I think it looks fine otherwise.

I will push it tomorrow if you don't have objections.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list