[Bug 28707] Clarify how to use hold/mute with Call

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Mar 8 19:13:50 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=28707

--- Comment #11 from Olivier Crête <olivier.crete at ocrete.ca> 2011-03-08 10:13:50 PST ---
(In reply to comment #10)
> (In reply to comment #8)
> > Meeting notes, needs drafting:
> > 
> > 1. Merge mute to Content and Call
> There is already Content.Interface.Mute. Do you want it put into the main
> Content interface or what? You want it duplicated in Call? Why?

We decided mute wasn't optional. The reason to duplicate it in Call is just to
make it easier for applications.

> > 3. Keep directions on Stream
> Not sure what you mean here. Also: what do you want doing with
> Call.Stream.RemoteMembers (map between contacts and their Sending State).

I meant that SetSending/RequestReceiving() would stay on the Stream Interface.

> > Stream.I.Media:
> > Prop: SendingState: Not-Sending, PendingSend, PendingNotSend
> Made this enum Stream_Flow_State, with equivalents for these states, and also
> "flowing".
> 
> > + Reason (enum:
> > muted or hold or setsendingfalse or failed or temporary-failed)
> I'm not sure about the usefulness of having a Muted() callback, so I didn't
> include it in the draft (calling SendingStopped() in response to
> SendingStateChanged(PendingStop, Muted, "") sounds just as good)

Mute != SendingStopped... with mute you could continue sending, but send
silence. That's actually what your N900 does.

> > Method:
> > - SendingStarted()
> > - SendingFailed(enum, Ddbus error, Message)
> > - SendingStopped()
> > - Muted()
> > 
> > SendingFailed can be called at any time for errors
> 
> 
> > Same thing exists for s/Sending/Receiving/
> I started drafting it like that, but actually the Sending and Receiving cases
> are not quite symmetrical, are they? If you want to take a look at
> http://git.collabora.co.uk/?p=user/alsuren/telepathy-spec.git;a=shortlog;h=refs/heads/mute
> to make sure I'm on the right track then you can.

If you use the same enum for sending/receiving.. Rename Pending_SEnd... maybe
to Pending_Flow ..

I'm not how how its not symmetrical ?

> > Sending/ReceivingState properties on the stream ... with change notification
> > with error
> Hrrrm... Calling them the same thing on two different interfaces of the same
> object. That's going to get confusing. TODO.

If you have a better idea.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list