[Bug 30635] Telepathy-Idle fails to parse user list on irc.euirc.net

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30635

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-21 06:42:35 PDT ---
(In reply to comment #4)
> Created an attachment (id=44618)
 View: https://bugs.freedesktop.org/attachment.cgi?id=44618
 Review: https://bugs.freedesktop.org/review?bug=30635&attachment=44618

> Proposed fix

Looks good, I've applied it to master. Thanks!

The fix will be released in telepathy-idle 0.1.9, hopefully later this week.

> This is just a temporary hack. The proper way to do it would be to handle the
> RPL_ISUPPORT numeric
> (http://tools.ietf.org/html/draft-brocklesby-irc-isupport-03), and look for the
> PREFIX parameter.
> 
> However that will require more intrusive changes, and it is better to do it in
> a separate patch.

I've filed bug 35504 for this.

In a perfect world, the fix for this bug could have included a test case; but I
think that's the kind of thing that could also be folded into the more
intrusive changes. It's not like there was a test for the symbols Idle already
supported. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.