[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #20 from Debarshi Ray <debarshi.ray at gmail.com> 2011-03-29 14:11:24 PDT ---
(In reply to comment #16)
> (In reply to comment #12)
> > Review of attachment 44074 [details] [details]:
> > @@ +292,3 @@
> > +        g_value_set_static_boxed(value, getter_data);
> > +    else
> > +        g_value_set_uint(value, GPOINTER_TO_UINT(getter_data));
> > 
> > Does NULL really work as SupportedFields? It's meant to be a GPtrArray of
> > GValues, and part of me would expect dbus-glib to crash if you use NULL
> > instead.
> > 
> > (It took me a few moments to figure this out; maybe it would be clearer to
> > define the values in this function, rather than stashing them in getter_data
> > and casting it.)

> I am a bit clueless about properties and was just imitating Gabble code. I will
> try to look at it more closely.

I have fixed it now to return an empty GPtrArray.

I have also taken this opportunity to not use the 'getter_data' field, and just
directly return the value of the property. Makes the code a bit easier to read
in my opinion.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.