[Bug 35415] Allow the UI to specify extra-identities account paramaters.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35415

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-31 10:51:45 PDT ---
Just some style points:

http://git.collabora.co.uk/?p=user/stefw/telepathy-gabble.git;a=commitdiff;h=67837b88d14a70769ec65a159d36e53078b69351#patch3

Why not initialize those variables to NULL when they're declared? Not a big
thing though.

+  if (explicit_server != NULL && !tp_str_empty (explicit_server) &&

tp_str_empty checks for NULL so you don't have to.

Also I think this will conflict with the extra style patches you added to the
bug 35410 branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.