[Bug 41801] High level API for ContactBlocking

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41801

--- Comment #7 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-11-01 04:24:13 PDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > + * @n_contacts: the number of contacts in @contacts (must be at least 1)
> > > 
> > > but the code doesn't enforce that.
> > 
> > _tp_contacts_to_handles() now does.
> 
> It would be kinder to application developers to (also) g_return_if_fail()
> directly from the functions they actually call, so that the criticals in their
> terminal refer to something they do rather than the internals of tp-glib.

done.

> > > +      goto out;
> > > +    }
> > > +
> > > +  self->priv->contact_blocking_capabilities = tp_asv_get_uint32 (properties,
> > > +      "ContactBlockingCapabilities", &valid);
> > > +  if (!valid)
> > > +    {
> > > +      DEBUG ("Connection %s doesn't have ContactBlockingCapabilities
> > > property",
> > > +          tp_proxy_get_object_path (self));
> > > +    }
> > > +
> > > +out:
> > > 
> > > I don't really see that the goto buys us anything here.
> > 
> > removed.
> 
> I should have been clearer: I didn't mean “just blindly remove the goto”, I
> meant “use an else block”. Without the goto, it crashes because 'properties' is
> NULL.

Oh right it's not NULL-safe. fixed (squashed).

> > > +void _tp_connection_blocked_changed_queue_free (GQueue *queue)
> > > 
> > > Coding style: add a newline.
> > 
> > added.
> 
> Sorry, I should have been clearer: I didn't mean in the header. I meant in the
> .c file, between 'void' and '_tp_connection_blocked_changed_queue_free'.

Of course; changed (squashed).

For some reason
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=contact-blocking-41801
hates me and doesn't display the latest version of the branch?!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.